[Differential] [Changed Subscribers] D3140: Add formatters for application/pgp-keys and application/vnd.gnupg.wks body parts

[mlaurent (Laurent Montel)]

mlaurent added inline comments.

INLINE COMMENTS

> CMakeLists.txt:1
> +add_definitions(-DTRANSLATION_DOMAIN=\"messageviewer_application_gnupgwks_plugin\")
> +

You missed Messages.sh

> gnupgwksmemento.cpp:47
> +        : QObject(parent)
> +        , mGpgExec(QStringLiteral("gpg2"))
> +        , mUserId(userId)

Perhaps it will good to detect if we have gpg2 in system no ?

> gnupgwksmemento.cpp:205
> +GnuPGWKSMemento::GnuPGWKSMemento()
> +    : QObject(0)
> +    , Interface::BodyPartMemento()

Q_NULLPTR

REPOSITORY
  rKDEPIMADDONS KDE PIM Addons

REVISION DETAIL
  https://phabricator.kde.org/D3140

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: dvratil, aheinecke, bjoernbalazs
Cc: mlaurent, kde-pim, #kde_pim, spencerb, dvasin, winterz, vkrause, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20161023/8c0bd3b1/attachment.html>