[Differential] [Updated] D3140: Add formatters for application/pgp-keys and application/vnd.gnupg.wks body parts

[dvratil (Daniel Vrátil)]

dvratil marked 3 inline comments as done.
dvratil added a comment.


  - added Messages.sh
  - updated kdepim-addons.categories
  - coding style/code clean up

INLINE COMMENTS

> mlaurent wrote in gnupgwksmemento.cpp:47
> Perhaps it will good to detect if we have gpg2 in system no ?

> Perhaps it will good to detect if we have gpg2 in system no ?

It's a bit more difficult than that. Some distros have GnuPG2 binaries called "gpg", while some others have GnuPG2 binaries called "gpg2" (and GnuPG1 binaries called "gpg", possibly installed at the same time). We need to use GnuPG2 for this, so we try "gpg2" first, and if we get `QProcess::FailedToStart` error we try "gpg". If we would get error with "gpg", it means that either there's no "gpg" binary, or it's GnuPG1 binary (which does not understand the arguments).

I think it's easier and simpler to just try, rather than locating the binaries and parsing their "--version" output.

REVISION DETAIL
  https://phabricator.kde.org/D3140

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: dvratil, aheinecke, bjoernbalazs, mlaurent
Cc: mlaurent, kde-pim, #kde_pim, spencerb, dvasin, winterz, vkrause, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20161024/16550876/attachment.html>