[Differential] [Updated] D3140: Add formatters for application/pgp-keys and application/vnd.gnupg.wks body parts

[dvratil (Daniel Vrátil)]

dvratil marked 4 inline comments as done.
dvratil added a comment.


  Thanks Bjoern. The situation has simplified a little with Andre's suggestion to autodelete the email after user action, which means we have to handle much fewer states and thus much fewer messages :-)
  
  In https://phabricator.kde.org/D3140#58664, @bjoernbalazs wrote:
  
  > For the wording in the mails I would suggest something like: 
  >  "This is an automatically generated email. The purpose of this email is to:" and then add the purpose of the mail, so for the
  
  
  Won't an email starting with "This is an automatically generated email" just make users to shrug and hit the Delete key? That's my biggest concern here....
  
  > - first one (application/pgp-keys): "send your public key to your email provider. This way other people can easily send you encrypted emails (so no-one except from you and the sender can read the mails)."
  
  This one might not be automatically generated in some cases, could just be that someone simply sends you their public key via email, so the text should IMHO be generic enough to explain what it is with an action to allow users to import it into their keychain.
  
  What about:
  
    This is an OpenPGP key from John Smith <john at example.com>. You can use the key to exchange encrypted emails and files with this user and to verify authenticity of their emails.
    
    [ Show key details ] [ Import key ]
  
  "Show key details" just shows a bit more information (creation date, fingerprint, userid), "Import key" obviously imports it.
  
  Since Andre mentioned that pgp-keys can actually contains multiple keys, I'd simply handle it by showing the same "block" one for each key.
  
  > 
  > 
  > - Second one (application/vnd.gnupg.wks) "inform you, that your email provider has successfully received your public key. Other people can now easily send you encrypted emails (so no-one except from you and the sender can read the mails)."
  
  Right, this mime type can act in two situations:
  
  1. an email /from/ the provider asking you to confirm publication, so there needs to be an initial action from user: [ Click here to publish ] (which IMO implies having an explanation what this is all about at the top above the button). When clicked this generates and sends an email to provider which then finally publishes the key and there is no further response from the provider and we will delete this email (so no need to handle all the "Sending/Sent/Sent-but-not-yet-published/...") states.
  
  2. the email that we generated when user clicked the [ Click here to publish ] button in case 1), which means they will only see it if they click the email in their Outbox or Sent folder. Here I think we can say it's an automated email (we generated it after all) just fine:
  
    "This is an automatically generated email sent from KMail to your email provider to publish your key. Other people can now easily send you encrypted emails and verify authenticity of your emails"
  
  
  
  > For both: "Further action: Nothing required from you."
  > 
  > - Most problematic is when the key cannot be found in the WKD, because here the user actually needs to take action. A suggestion how to solve this:
  > 
  >   "This is an automatically generated email. The purpose of this email is to inform you that your email provider has not been able to publish your public key. All you can do is to re-send the information:
  > 
  >   Further action: [Re-send your public key to your email provider.]"
  
  This case is now gone, since we delete the email after successfully publishing the key, we don't need to worry about the key already being published or not.
  
  > What do you think?
  
  I think we should always start with explaining what this email is about rather than saying it's automatically generated (we can mention that somewhere below), to make sure people don't ignore it and get and can understand the purpose of the email as quickly as possible? That's just my uneducated opinion :)

REPOSITORY
  rKDEPIMADDONS KDE PIM Addons

REVISION DETAIL
  https://phabricator.kde.org/D3140

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: dvratil, aheinecke, mlaurent, bjoernbalazs
Cc: knauss, emanuel, mlaurent, kde-pim, #kde_pim, spencerb, dvasin, winterz, vkrause, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20161026/c208bd09/attachment.html>