Review Request 129266: fix: clicking on HTML Side Bar can no longer toggle html/plain text

Laurent Montel montel at kde.org
Thu Oct 27 06:27:53 BST 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129266/#review100321
-----------------------------------------------------------


Ship it!




It seems to work.
So commit it in 16.08 and after that we will merge in master
thanks.

- Laurent Montel


On Oct. 26, 2016, 3:53 p.m., Martin Koller wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129266/
> -----------------------------------------------------------
> 
> (Updated Oct. 26, 2016, 3:53 p.m.)
> 
> 
> Review request for KDEPIM and Laurent Montel.
> 
> 
> Bugs: 367997
>     https://bugs.kde.org/show_bug.cgi?id=367997
> 
> 
> Repository: messagelib
> 
> 
> Description
> -------
> 
> clicking on the HTML bar changes the display to plain text and in that process also changes the availableModes member of this class (via MimeTreeParser::DefaultRendererPrivate -> MessageViewer::MailViewerSource::setHtmlMode)
> 
> Simply setting it back to how it was before the click solves the issue.
> 
> 
> Diffs
> -----
> 
>   messageviewer/src/viewer/viewer_p.cpp e87a9da 
> 
> Diff: https://git.reviewboard.kde.org/r/129266/diff/
> 
> 
> Testing
> -------
> 
> yes.
> 
> 
> Thanks,
> 
> Martin Koller
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20161027/fa845609/attachment.html>


More information about the kde-pim mailing list