Review Request 129125: Remove unused dependencies in libkgapi

Daniel Vrátil dvratil at kde.org
Sun Oct 9 13:19:36 BST 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129125/#review99874
-----------------------------------------------------------


Ship it!




Ship It!

- Daniel Vrátil


On Oct. 8, 2016, 7:18 p.m., Michael Palimaka wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129125/
> -----------------------------------------------------------
> 
> (Updated Oct. 8, 2016, 7:18 p.m.)
> 
> 
> Review request for KDEPIM and Daniel Vrátil.
> 
> 
> Repository: libkgapi
> 
> 
> Description
> -------
> 
> This is two commits:
> 
> 1. I was not able to find any usage of KF5CoreAddons, so remove it.
> 
> 2. Remove a stray reference to Qt5::WebKitWidgets (Qt5WebKit is no longer used).
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 14709e64ec5177bd3b554825cdc910f4d35e0243 
>   KF5GAPIConfig.cmake.in 7e5a50a8b5585ad3212b2d0053e9b6f4fd6435d3 
>   src/core/CMakeLists.txt ae85c18fa8e8c82cf2cd48d909c20ab0a2164378 
> 
> Diff: https://git.reviewboard.kde.org/r/129125/diff/
> 
> 
> Testing
> -------
> 
> Builds, tests pass.
> 
> 
> Thanks,
> 
> Michael Palimaka
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20161009/8b910a04/attachment.html>


More information about the kde-pim mailing list