Review Request 129558: Update konsolekalendar docbook to kf5

Sandro Knauß sknauss at kde.org
Sat Nov 26 13:50:31 GMT 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129558/#review101126
-----------------------------------------------------------




doc/konsolekalendar/index.docbook (line 295)
<https://git.reviewboard.kde.org/r/129558/#comment67772>

    [...]the calendar first  using the --create paramenter with the filename as argument. The file must have be a valid iCal or vCal file.
    
    ^^ The wording is bad, maybe you find a better description. But we need no --calendar parameter for --create.
    
    Also add a notice, that there is no dry-run for this. To delete calendars, you need korgnaizer or akonadiconsole, both GUI-Tools.



doc/konsolekalendar/index.docbook (line 475)
<https://git.reviewboard.kde.org/r/129558/#comment67773>

    skipping identical events, that are already part of the calendar.



doc/konsolekalendar/index.docbook (line 575)
<https://git.reviewboard.kde.org/r/129558/#comment67774>

    please add the upcomming argument filename see https://phabricator.kde.org/D3510.
    remove the "if one does not exist.", this is not true anymore.


- Sandro Knauß


On Nov. 26, 2016, 12:54 p.m., Burkhard Lück wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129558/
> -----------------------------------------------------------
> 
> (Updated Nov. 26, 2016, 12:54 p.m.)
> 
> 
> Review request for Documentation, KDEPIM and Sandro Knauß.
> 
> 
> Bugs: 346221
>     https://bugs.kde.org/show_bug.cgi?id=346221
> 
> 
> Repository: akonadi-calendar-tools
> 
> 
> Description
> -------
> 
> remove entities kappname + package, no longer used
> bump date + releaseinfo
> remove &kde;
> update options
> remove appendix installation
> 
> 
> Diffs
> -----
> 
>   doc/konsolekalendar/index.docbook 56d7734 
> 
> Diff: https://git.reviewboard.kde.org/r/129558/diff/
> 
> 
> Testing
> -------
> 
> passes checkXML5
> 
> 
> Thanks,
> 
> Burkhard Lück
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20161126/a76d5934/attachment.html>


More information about the kde-pim mailing list