[Differential] [Commented On] D3214: Implement key publishing in Account Wizard

[aheinecke (Andre Heinecke)]

aheinecke added a comment.


  I think you can commit this (with a fix for the error state) and we improve incrementally.
  
  Some improvements I see:
  
  1. You can not open a second kmail-account-wizard while the key generation still runs.
  2. An existing key is not preselected.
  3. Generate Key immediately pops up the passphrase entry / starts keygen this is too early (should happen on next).
    - The problem is that you can create multiple keys if you unselect generate key and select it again.
  4. I don't think the pop up for the passphrase is the best solution. I think dynamically adding the passphrase entry widget to the wizard page when generate-key is selected. Otherwise we could have used the existing pinentries. Or we have the widget there and only enable / disable this.

INLINE COMMENTS

> cryptopage.cpp:234
> +                [](const QString &msg) {
> +                    KNotification::event(KNotification::Error, i18n("Account Wizard"),
> +                                         msg, QStringLiteral("akonadi"));

I encountered this error because gpg-wks-client --create crashes in current gpg master ( https://bugs.gnupg.org/gnupg/issue2828 ). The condition caused kmail-account-wizard not to terminate. The error probably needs to be connected to some finished / delete later slot?

REPOSITORY
  R207 KMail Account Wizard

REVISION DETAIL
  https://phabricator.kde.org/D3214

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: dvratil, aheinecke
Cc: mlaurent, knauss, kde-pim, spencerb, dvasin, winterz, vkrause, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20161107/8c4e9f9f/attachment.html>