Review Request 129264: handle mysql process crashes gracefully

[Daniel Vrátil]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129264/#review100500
-----------------------------------------------------------




src/server/storage/dbconfigmysql.cpp 
<https://git.reviewboard.kde.org/r/129264/#comment67445>

    Either this has to stay here, or stopInternalServer() must be adjusted to not just give up when mDatabaseProcess is null, but still try to shutdown the DB via mCleanServerShutdownCommand.



src/server/storage/dbconfigmysql.cpp (line 465)
<https://git.reviewboard.kde.org/r/129264/#comment67446>

    4 spaces indent



src/server/storage/dbconfigmysql.cpp (line 466)
<https://git.reviewboard.kde.org/r/129264/#comment67447>

    Hmm, I'm wondering if this is maybe too brutal? What if the server is still running, just refuses our connection (for any reason)? Deleting the socket of a running server might not be a smart thing to do in that case....:-)


- Daniel Vrátil


On Oct. 31, 2016, 10:49 a.m., Martin Koller wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129264/
> -----------------------------------------------------------
> 
> (Updated Oct. 31, 2016, 10:49 a.m.)
> 
> 
> Review request for Akonadi and Daniel Vrátil.
> 
> 
> Repository: akonadi
> 
> 
> Description
> -------
> 
> It happened to me that I started kmail but could not see any mail folder.
> Searching I found that although all akonadi processes were running, the mysqld process was not,
> so it seems for whatever reason mysqld crashed (using a privately started mysqld from akonadiserver).
> 
> This patch checks if the mysqld stops unexpectedly when it was started from akonadiserver and tells the latter to quit when a stopped mysqld was discovered.
> Also in this case the local socket file is removed so that a restart can work without problem.
> 
> 
> Diffs
> -----
> 
>   src/server/storage/dbconfigmysql.h 27841e8 
>   src/server/storage/dbconfigmysql.cpp 0962ccb 
> 
> Diff: https://git.reviewboard.kde.org/r/129264/diff/
> 
> 
> Testing
> -------
> 
> Started akonadi via akonadictl and also implicitely via kmail, then killed (-4, -15) mysqld.
> Restarted via akonadictl or kmail
> 
> 
> Thanks,
> 
> Martin Koller
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20161102/dc61fe0b/attachment.html>