Review Request 129346: Do not assert in dav resource calling ResourceBase::collectionsRetrieved from custom job

[Daniel Vrátil]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129346/#review100751
-----------------------------------------------------------



This is not the correct fix. If the resource wants to synchronize collections it should simply call `ResourceBase::synchronizeCollectionTree()` instead of scheduling custom tasks with side-effects.

- Daniel Vrátil


On Nov. 6, 2016, 10:04 a.m., Martin Koller wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129346/
> -----------------------------------------------------------
> 
> (Updated Nov. 6, 2016, 10:04 a.m.)
> 
> 
> Review request for Akonadi and Daniel Vrátil.
> 
> 
> Repository: akonadi
> 
> 
> Description
> -------
> 
> ResourceBase::collectionsRetrieved assumes it must be called from either a Sync or SyncAll task.
> The dav resource however does this from a Custom task.
> 
> Therefore the dav resource always crashes (asserts) in a debug build.
> 
> This patch simply also allows the Custom Task.
> 
> 
> Diffs
> -----
> 
>   src/agentbase/resourcebase.cpp 64be61e 
> 
> Diff: https://git.reviewboard.kde.org/r/129346/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Koller
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20161109/3a25a2d0/attachment.html>