Review Request 129403: CMakeLists.txt: Remove unused variable
Andre Heinecke
aheinecke at intevation.de
Mon Nov 14 16:47:38 GMT 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129403/#review100837
-----------------------------------------------------------
Ship it!
You are right. I've removed pimcommon as a dependency but overlooked this variable.
- Andre Heinecke
On Nov. 14, 2016, 4:29 p.m., Heiko Becker wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129403/
> -----------------------------------------------------------
>
> (Updated Nov. 14, 2016, 4:29 p.m.)
>
>
> Review request for KDEPIM, Andre Heinecke and Laurent Montel.
>
>
> Repository: libkleo
>
>
> Description
> -------
>
> PIMCOMMON_LIB_VERSION isn't used anywhere and pimcommon isn't even
> an actual dependency of libkleo.
>
>
> Diffs
> -----
>
> CMakeLists.txt ba88d482888a1f9fb0694e27af2980dabfe5db5b
>
> Diff: https://git.reviewboard.kde.org/r/129403/diff/
>
>
> Testing
> -------
>
> It builds successfully.
>
>
> Thanks,
>
> Heiko Becker
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20161114/747ef057/attachment.html>
More information about the kde-pim
mailing list