[Differential] [Commented On] D3214: Implement key publishing in Account Wizard

[aheinecke (Andre Heinecke)]

aheinecke added inline comments.

INLINE COMMENTS

> cryptopage.cpp:91
>                  this, &KeyGenerationJob::keyGenerated);
> -        job->start(setupManager->name(), setupManager->email());
> +        job->start(mName, mEmail);
>      }

Ah, It's DefaultKeyGenerationJob::start(const QString &email, const QString &name);

This is likely the reason why we don't get responses for these keys because they are dropped on the server. Because they don't contain a valid user ID. gpg-wks-client should have errored out instead of sending a public key without userids. I'll open a gnupg issue for that.

Didn't notice it on the commandline either but you can see that keys created by them have email <Name> when listing them on the command line,

REPOSITORY
  R207 KMail Account Wizard

REVISION DETAIL
  https://phabricator.kde.org/D3214

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: dvratil, aheinecke
Cc: mlaurent, knauss, kde-pim, spencerb, dvasin, winterz, vkrause, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20161109/41eb15e0/attachment.html>