Review Request 129408: Remove unused dependencies

Laurent Montel montel at kde.org
Fri Nov 18 12:13:58 GMT 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129408/#review100928
-----------------------------------------------------------


Ship it!




Ship it.

- Laurent Montel


On Nov. 15, 2016, 12:25 p.m., Heiko Becker wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129408/
> -----------------------------------------------------------
> 
> (Updated Nov. 15, 2016, 12:25 p.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Repository: akonadi-calendar-tools
> 
> 
> Description
> -------
> 
> Both KF5AkonadiContact and KF5Contacts appear to be not necessary and
> not used anywhere. ${AKONADI_CONTACT_VERSION} wasn't even set, but
> ${AKONADI_MIMELIB_VERSION}, which was never used to find anything.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 0ad317a 
> 
> Diff: https://git.reviewboard.kde.org/r/129408/diff/
> 
> 
> Testing
> -------
> 
> Still builds fine.
> 
> Not sure if removing fake dependencies is ok during dependency freeze.
> If not, I'd push it only to master after the Applications/16.12 branch
> is created.
> 
> 
> Thanks,
> 
> Heiko Becker
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20161118/51de7129/attachment.html>


More information about the kde-pim mailing list