Review Request 129558: Update konsolekalendar docbook to kf5

Sandro Knauß sknauss at kde.org
Fri Nov 25 20:17:34 GMT 2016



> On Nov. 25, 2016, 2:25 p.m., Sandro Knauß wrote:
> > doc/konsolekalendar/index.docbook, line 305
> > <https://git.reviewboard.kde.org/r/129558/diff/1/?file=486559#file486559line305>
> >
> >     I would recomend (please test with uptodate konsolecalendar) to name the file vacation.ics and use this name "vacation.ics" in the calendar options, than it is more obvious what you set there.
> 
> Burkhard Lück wrote:
>     Quoting my comment on line 301:
>     "<!--FIXME is this correct, it does not work for me -->"
>     
>     therefore I can not do what you requested, sorry

Well the code was dead to import :)

I fixed that in https://phabricator.kde.org/D3509 (keep in mind also kdepim is moving to phabricator to manage Review requests).

When the code is added the import works like this:

*get calendarslist (fixed with patch today)
 
  $ konsolekalendar --list-calendars
  [...]
  7     - (Read only) Open Invitations
  8     - (Read only) Declined Invitations
  9     - Persönlicher Kalender
  
* you can pretest what import will do, the calendar is the calendarid (see above)
  $ konsolekalendar --import /tmp/test.ics --calendar 9  --dry-run --verbose
  Add Event with uid "KOrganizer-1943585507.454". <Verbose>
  Add Event with uid "KOrganizer-135574846.1006". <Verbose>
  Add Event with uid "KOrganizer-949295754.111". <Verbose>
  Calendar /tmp/test.ics successfully imported

* actually import calendar file
  $ konsolekalendar --import /tmp/test.ics --calendar 9                     
  Calendar /tmp/test.ics successfully imported

* afterwards it detects, that the events are already imported (only shown with verbose):
  $ konsolekalendar --import /tmp/test.ics --calendar 9 --verbose
  Insert Event skipped, because uid "KOrganizer-1943585507.454" is already known. <Verbose>
  Insert Event skipped, because uid "KOrganizer-949295754.111" is already known. <Verbose>
  Insert Event skipped, because uid "KOrganizer-135574846.1006" is already known. <Verbose>
  Calendar /tmp/test.ics successfully imported

create was broken, too. Fixed with https://phabricator.kde.org/D3510
  
  $konsolekalendar --create /tmp/foo.ics
  
  this creates a configures Akonadi Resource pointing to this file, the file basename is used as name.


- Sandro


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129558/#review101115
-----------------------------------------------------------


On Nov. 25, 2016, 11:57 a.m., Burkhard Lück wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129558/
> -----------------------------------------------------------
> 
> (Updated Nov. 25, 2016, 11:57 a.m.)
> 
> 
> Review request for Documentation, KDEPIM and Sandro Knauß.
> 
> 
> Bugs: 346221
>     https://bugs.kde.org/show_bug.cgi?id=346221
> 
> 
> Repository: akonadi-calendar-tools
> 
> 
> Description
> -------
> 
> remove entities kappname + package, no longer used
> bump date + releaseinfo
> remove &kde;
> update options
> remove appendix installation
> 
> 
> Diffs
> -----
> 
>   doc/konsolekalendar/index.docbook 56d7734 
> 
> Diff: https://git.reviewboard.kde.org/r/129558/diff/
> 
> 
> Testing
> -------
> 
> passes checkXML5
> 
> 
> Thanks,
> 
> Burkhard Lück
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20161125/feccbda0/attachment.html>


More information about the kde-pim mailing list