[Differential] [Updated] D3387: NodeHelper::fromAsString: make it work with extra content nodes

[dvratil (Daniel Vrátil)]

dvratil marked an inline comment as done.
dvratil added inline comments.

INLINE COMMENTS

> knauss wrote in nodehelpertest.cpp:244
> I also would like to have a more complex test case aka:
> 
>   toplevel (toplvel@)
>   -> sub -> toplevel@
>   ->an attached rfc822 mail with own sender -> second@
>      -> subsub -> second@
> 
> and for all 4 parts make sure that th correct from address is returned and for all extra parts, that must return the correct value.

That actually would not be compatible with the current behavior and is beyond the scope of this change (IMO). NodeHelper::fromAsString() returns sender of the top-level message, which always is a KMime::Content with a null parent. Even for an encapsulated message this function always returns a sender of the top-level message.

I can add X_FAIL test cases so we know this should be fixed/solved, but the correct detection of nested sub-message may be non-trivial and might break some other code that might rely on the current behaviour.

REPOSITORY
  rMESSAGELIB PIM: Message Library

REVISION DETAIL
  https://phabricator.kde.org/D3387

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: dvratil, knauss
Cc: kde-pim, #kde_pim, spencerb, dvasin, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20161118/e1357226/attachment.html>