[Kde-pim] Review Request 127845: Fix message

Frederik Schwarzer schwarzer at kde.org
Thu May 5 23:05:45 BST 2016



> On May 5, 2016, 9:27 p.m., Allen Winter wrote:
> > src/acl/aclmodifyjob.cpp, line 180
> > <https://git.reviewboard.kde.org/r/127845/diff/1/?file=464187#file464187line180>
> >
> >     how about:
> >     
> >     "Do you really want to apply the folder's permissions to these subfolders?"

Hmm, yes, if folderNames refers to the subfolders and the "folder" in question is singular, your suggestion is correct. Can anyone confirm this?


- Frederik


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127845/#review95216
-----------------------------------------------------------


On May 5, 2016, 8:45 p.m., Frederik Schwarzer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127845/
> -----------------------------------------------------------
> 
> (Updated May 5, 2016, 8:45 p.m.)
> 
> 
> Review request for KDEPIM, KDEPIM-Libraries and Laurent Montel.
> 
> 
> Repository: pimcommon
> 
> 
> Description
> -------
> 
> Since folderNames is plural, we need proper plural here.
> 
> 
> Diffs
> -----
> 
>   src/acl/aclmodifyjob.cpp 7064207 
> 
> Diff: https://git.reviewboard.kde.org/r/127845/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Frederik Schwarzer
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


More information about the kde-pim mailing list