[Kde-pim] [Differential] [Updated] D1636: Implement client-side threading cache

[dvratil (Daniel Vrátil)]

dvratil marked 6 inline comments as done.
dvratil added a comment.


  Thanks for the review. I'd really appreciate someone checking the logic in the Model itself, but I realize that might be a bit time consuming. I did my best to understand the threading code (it looks more complicated than it really is), but of course I could've missed some edge-case scenario.

INLINE COMMENTS

> dfaure wrote in threadingcache.cpp:40
> Why is this instance a global variable? It looks like it's only used in one method.

Copy-paste mistake.

> dfaure wrote in threadingcache.cpp:136
> Should this use QSaveFile to avoid partially written out files in case of full partition? On the other hand I suppose not using QSaveFile is slightly faster so if we can handle truncated files gracefully....

I added flush() after writing the CacheHeader, so if the file gets truncated, we will detect it while loading it the next time because we will reach EOF before reading CacheHeader::cacheSize records.

REPOSITORY
  rMESSAGELIB PIM: Message Library

REVISION DETAIL
  https://phabricator.kde.org/D1636

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: dvratil, mlaurent, vkrause, dfaure
Cc: kde-pim, dvasin, winterz, smartins, vkrause, mlaurent, knauss, dvratil
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/