[Kde-pim] [Differential] [Commented On] D1636: Implement client-side threading cache

[dfaure (David Faure)]

dfaure added inline comments.

INLINE COMMENTS

> threadingcache.cpp:136
> +    QFile cacheFile(cacheDir.filePath(QStringLiteral("messagelist/threading/%1").arg(mCacheId)));
> +    if (!cacheFile.open(QIODevice::WriteOnly | QIODevice::Truncate)) {
> +        qCWarning(MESSAGELIST_LOG) << "Failed to create cache file:" << cacheFile.errorString();

Should this use QSaveFile to avoid partially written out files in case of full partition? On the other hand I suppose not using QSaveFile is slightly faster so if we can handle truncated files gracefully....

REPOSITORY
  rMESSAGELIB PIM: Message Library

REVISION DETAIL
  https://phabricator.kde.org/D1636

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: dvratil, mlaurent, vkrause, dfaure
Cc: kde-pim, dvasin, winterz, smartins, vkrause, mlaurent, knauss, dvratil
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/