[Kde-pim] [Differential] [Request, 24 lines] D1652: Remove moveCompletionPopup() hack.

[dfaure (David Faure)]

dfaure created this revision.
Restricted Application added a project: KDE PIM.
Restricted Application added a subscriber: kde-pim.

REVISION SUMMARY
  1. commit b78a77e95659 in kdelibs 4.9.2 (see bug 270473) takes
  
  care of making KCompletionBox move/resize when the parent widget has moved/resized.
  
  2. this hack made the completion popup not appear for me, the very first time.
  
  After hide()+show(), isVisible() was true, but the popup wasn't actually visible
  (geometry was correct though). Possibly a Qt issue, but that's what we get when
  doing hacks.

TEST PLAN
  Ctrl+N, @, no popup appears. And this breaks the Tab key since the code thinks it's visible...
  
  Question: is such a BIC change OK or do I need to keep and deprecate the virtual method?

REPOSITORY
  rLIBKDEPIM PIM: Libraries

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D1652

AFFECTED FILES
  src/multiplyingline/multiplyingline.h
  src/multiplyingline/multiplyinglineview_p.cpp
  src/multiplyingline/multiplyinglineview_p.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: dfaure
Cc: kde-pim, dvasin, winterz, smartins, vkrause, mlaurent, knauss, dvratil
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/