[Kde-pim] [Differential] [Request, 42 lines] D1614: WebEngine-based messageviewer: fix PageUp/PageDown
dfaure (David Faure)
noreply at phabricator.kde.org
Sun May 15 14:38:28 BST 2016
dfaure created this revision.
Restricted Application added a project: KDE PIM.
Restricted Application added a subscriber: kde-pim.
REVISION SUMMARY
Instead of moving to the bottom of the document, only move down 87.5% of the viewport height.
This number was found in the QtWebkit sources.
Now I see that kmail4 was doing 80% on PageDown and 100% on Key_Space. Should we keep that instead?
TEST PLAN
PageUp/PageDown in kmail master.
REPOSITORY
rMESSAGELIB PIM: Message Library
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D1614
AFFECTED FILES
messageviewer/src/viewer/viewer.cpp
messageviewer/src/viewer/viewer.h
messageviewer/src/viewer/webengine/mailwebengineview.cpp
messageviewer/src/viewer/webengine/mailwebengineview.h
webengineviewer/src/tests/testwebenginescript.cpp
webengineviewer/src/webenginescript.cpp
webengineviewer/src/webenginescript.h
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: dfaure
Cc: kde-pim, dvasin, winterz, smartins, vkrause, mlaurent, knauss, dvratil
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/
More information about the kde-pim
mailing list