[Kde-pim] Review Request 127966: Port all instances of Kauthorized action/shell_command to shell_command

David Edmundson david at davidedmundson.co.uk
Mon May 23 11:08:18 BST 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127966/
-----------------------------------------------------------

(Updated May 23, 2016, 12:08 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDEPIM and Laurent Montel.


Changes
-------

Submitted with commit 99007b55b9ea9a2db7afdee97ba81f4a406d94bd by David Edmundson to branch master.


Repository: kdepim


Description
-------

The KAuthorized key to prevent shell access according the documentation
is simply "shell_action" not "action/shellAction" so should use
authorize not authorizeKAction

This appears to have come about as part of a porting bug when going from
KApplication::authorize to KAuthorized in kdelibs3 to kdelibs4.

To currently block shell access a sysadmin currently needs to
have both keys set already, so we can be confident it won't have any
actual compatibility problems.


Diffs
-----

  kalarm/src/lib/shellprocess.cpp c3f90acc19233319944fc7aeaecf69b35c9aef9b 

Diff: https://git.reviewboard.kde.org/r/127966/diff/


Testing
-------


Thanks,

David Edmundson

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


More information about the kde-pim mailing list