[Kde-pim] [Differential] [Updated] D1702: Remove event from KCalCore::MemoryCalendar before removing it from Akonadi::CalendarBase

[smartins (Sergio Martins)]

smartins added a comment.


  iirc, MemoryCalendar::deleteIncidence() triggers observer code, which is external to us, so can do anything, even try to delete the incidence again. There was a bug that was fixed this way, no idea which, very long time ago :P
  
  I think a cleaner approach would be for CalendarBase to call Calendar::notifyIncidenceAboutToBeDeleted() before hash cleanup and notifyIncidenceDeleted() after MemoryCalendar::deleteIncidence() (and some way for MemoryCalendar::deleteIncidence() not call those)

REPOSITORY
  rAKONADICALENDAR Akonadi-Calendar

REVISION DETAIL
  https://phabricator.kde.org/D1702

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: dvratil, smartins
Cc: kde-pim, dvasin, winterz, smartins, vkrause, mlaurent, knauss, dvratil
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/