[Kde-pim] Review Request 127181: Add a 'trust owner' dialog for newly imported secret keys

[Sean Engelhardt]

> On March 1, 2016, 4:05 p.m., Andre Heinecke wrote:
> > kleopatra/commands/importcertificatescommand.cpp, line 411
> > <https://git.reviewboard.kde.org/r/127181/diff/2/?file=446204#file446204line411>
> >
> >     Space after braces still a style issue in this patch.
> >     You can also use longer lines.
> >     
> >     Sorry if this appears to be annoying but if we afterwards run tools on this to unify coding style this breaks history so new commits should follow coding style guidelines.

> You can also use longer lines.

According to https://techbase.kde.org/Policies/Kdelibs_Coding_Style#Line_breaks
Lines should be <= 100 characters.

I usualy took 80 course of habits.


> On March 1, 2016, 4:05 p.m., Andre Heinecke wrote:
> > kleopatra/commands/importcertificatescommand.cpp, line 432
> > <https://git.reviewboard.kde.org/r/127181/diff/2/?file=446204#file446204line432>
> >
> >     Please reduce this to the fingerprint and pretty (name and email) user ID's but all UID's and not just the first one.
> >     
> >     Fingerprint first and most prominent below UID's without caption.
> >     
> >     See utils/formatting.cpp Formatting::prettyUserID.
> >     
> >     Create a string list of prettyUserID's join them with \n and insert in the string.
> >     
> >     This should come closest to the info available on the command line.
> >     
> >     Btw. although GnuPG does not allow this, Keys without any UID are OpenPGP compliant and this could also happen when you import an ECC key using GnuPG 2.0 as GnuPG only handles UID's with a valid selfsig and GnuPG 2.0 can't handle ECC Signatures.

please check the new version again and mark this as fixed if the patch is appropriate.


- Sean


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127181/#review93010
-----------------------------------------------------------


On March 10, 2016, 12:04 p.m., Sean Engelhardt wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127181/
> -----------------------------------------------------------
> 
> (Updated March 10, 2016, 12:04 p.m.)
> 
> 
> Review request for KDEPIM and Andre Heinecke.
> 
> 
> Repository: kdepim
> 
> 
> Description
> -------
> 
> When importing a new secret key in Kleopatra, a dialog-window will pop up to determinate if the owner of the newly imported key should be trusted or not.
> Since imported secret keys are usually the own ones it would make sense to enhance the trusting-process.
> 
> 
> Diffs
> -----
> 
>   kleopatra/commands/importcertificatescommand.cpp 18a65d1 
> 
> Diff: https://git.reviewboard.kde.org/r/127181/diff/
> 
> 
> Testing
> -------
> 
> Imported newly generated keys to determinate if the script gets triggered and works as requested.
> 
> -edited version after the 1. reviewing process. Changed according to the requests. Propably found a bug in kleo.
> 
> -edited version after the 2. reviewing process. Changed the spaches beforce and after the braces, removed logging for S/Mime keys, adjusted the dialog.
> 
> 
> Thanks,
> 
> Sean Engelhardt
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/