[Kde-pim] Review Request 127453: [kimap] Introduce StatusJob for the STATUS command

[Sandro Knauß]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127453/#review93861
-----------------------------------------------------------




autotests/statusjobtest.cpp (line 20)
<https://git.reviewboard.kde.org/r/127453/#comment63948>

    one #include <QTest> is enough :D



autotests/statusjobtest.cpp (line 90)
<https://git.reviewboard.kde.org/r/127453/#comment63949>

    You need a unique row name. According to line 109 it should be called "bad".


- Sandro Knauß


On März 21, 2016, 8:45 nachm., Daniel Vrátil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127453/
> -----------------------------------------------------------
> 
> (Updated März 21, 2016, 8:45 nachm.)
> 
> 
> Review request for KDEPIM, Kevin Ottens, Sandro Knauß, and Laurent Montel.
> 
> 
> Repository: kimap
> 
> 
> Description
> -------
> 
> Need this to fix Courier IMAP support in the IMAP resource.
> 
> I'd like to ask for freeze exception and get this still to 16.04 (so I can fix the Courier bugs).
> 
> 
> Diffs
> -----
> 
>   autotests/CMakeLists.txt e633b9b 
>   autotests/statusjobtest.cpp PRE-CREATION 
>   src/CMakeLists.txt d661c15 
>   src/statusjob.h PRE-CREATION 
>   src/statusjob.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/127453/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Daniel Vrátil
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/