[Kde-pim] Review Request 127502: pop3: Try sending the command again if the server disconnected us

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127502/#review94043
-----------------------------------------------------------



Thinking about this I am not sure this is the best idea since I'm not sure that in between connections the ids of the emails are guaranteed to be the same, probably they will because well, we were just sending commands but I will try to figure out what takes so much time in between sending the RETR and the DELE commands and that is probably a way for the server to not close the connection on me.

- Albert Astals Cid


On March 26, 2016, 5:29 p.m., Albert Astals Cid wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127502/
> -----------------------------------------------------------
> 
> (Updated March 26, 2016, 5:29 p.m.)
> 
> 
> Review request for KDEPIM and KDEPIM-Libraries.
> 
> 
> Repository: kdepimlibs
> 
> 
> Description
> -------
> 
> It happens to me that sometimes the yahoo server disconnects me, specially between the fetch and the delete stages because after the fetch something in the pop3 resource takes a while and the yahoo server decides to kick me out.
> 
> So if sendCommand writes because we have been disconnected from the server, try disconnecting/connecting and sending the command again.
> 
> This needs https://git.reviewboard.kde.org/r/127501 to actually work.
> 
> 
> Diffs
> -----
> 
>   kioslave/src/pop3/pop3.h 97a6898 
>   kioslave/src/pop3/pop3.cpp a3c791f 
> 
> Diff: https://git.reviewboard.kde.org/r/127502/diff/
> 
> 
> Testing
> -------
> 
> It works better now and is able to recover from server disconnections.
> 
> 
> Thanks,
> 
> Albert Astals Cid
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/