[Kde-pim] Review Request 127224: Kleopatra: Update AboutData and Gpg4win About Data

[Andre Heinecke]

> On Feb. 29, 2016, 8:10 p.m., Laurent Montel wrote:
> > kleopatra/aboutdata.cpp, line 183
> > <https://git.reviewboard.kde.org/r/127224/diff/1/?file=446037#file446037line183>
> >
> >     Still necessary ? all is empty no ?
> 
> Andre Heinecke wrote:
>     Without this the Author tab was not shown at all in the AboutDialog.
> 
> Laurent Montel wrote:
>     it seems to be a bug in framework so.
>     Ok so ship it.

I don't think it's a bug. If you don't have authors it normally makes no sense to show Authors. Also the Tab name is singular "Author" in case you only add one Author and plural "Authors" if you have more then one.

Gpg4win abuses this mechanism a bit as Gpg4win wanted to have "A consortium of Companies as author" (But without using the list of authors and instead a custom author page text)

I'll add a comment above the addAuthor call to explain why it's there and will then ship it.


- Andre


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127224/#review92933
-----------------------------------------------------------


On Feb. 29, 2016, 4:43 p.m., Andre Heinecke wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127224/
> -----------------------------------------------------------
> 
> (Updated Feb. 29, 2016, 4:43 p.m.)
> 
> 
> Review request for KDEPIM and Laurent Montel.
> 
> 
> Repository: kdepim
> 
> 
> Description
> -------
> 
> Change maintainer to myself and add Laurent in the credits section.
> Mark copyright for the last years to generic "Kleopatra developers". (Similar to Kontact. I think it's strange to attribute copyright to just one person for some years.)
> Slightly fix Gpg4win authors. The old code had a broken layout
> as all contributors were "squashed" into a single Author field. Still a bit weird how the Gpg4win Author data is done but I don't know what the people did / if it would be ok to add their E-Mails. So I've decided against making proper "Authors" of the Gpg4win contributors.
> 
> 
> Diffs
> -----
> 
>   kleopatra/aboutdata.cpp 38465a5 
>   kleopatra/mainwindow.cpp 9349c75 
> 
> Diff: https://git.reviewboard.kde.org/r/127224/diff/
> 
> 
> Testing
> -------
> 
> Looked at it on Linux and Windows.
> 
> 
> Thanks,
> 
> Andre Heinecke
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/