[Kde-pim] Review Request 127348: [KPeople] Set the contact uri as person uri in PersonData when no person exists

Martin Klapetek martin.klapetek at gmail.com
Mon Mar 14 12:55:49 GMT 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127348/
-----------------------------------------------------------

(Updated March 14, 2016, 1:55 p.m.)


Review request for KDE Frameworks and KDEPIM.


Changes
-------

Extend the test to the second testcase


Repository: kpeople


Description
-------

For single contact without any person, PersonData does not work. This uses the contact uri as a person uri in that case, making things work. It also mirrors what PersonsModel does.


Diffs (updated)
-----

  autotests/persondatatests.cpp 5f7cabd 
  src/persondata.cpp 4586bac 

Diff: https://git.reviewboard.kde.org/r/127348/diff/


Testing
-------

PersonData returns correct data


Thanks,

Martin Klapetek

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


More information about the kde-pim mailing list