[Kde-pim] Review Request 127230: [console] Dissolve it and move applications up one level

[Andreas Sturmlechner]

> On March 1, 2016, 6:20 a.m., Laurent Montel wrote:
> > I don't see the usefull...
> > If you want to use option for it add option in console/CMakeLists.txt directly.
> > It's console application so directory is console...
> > 
> > Regards

The question is, how important is the console distinction really? I have no strong opinion there, and since kdepim.git/ is less crowded with directories recently... ;)

It's only packaging convenience, that the project structure would be more uniform - several parts of kdepim can be built independently at this point, so the same code that e.g. splits apart blogilo and akonadiconsole (and injects handbook subdir) would also apply to console applications. Yes, making them optional within console dir is possible as well, but doesn't remove that bit of extra handling.


- Andreas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127230/#review92961
-----------------------------------------------------------


On Feb. 29, 2016, 10:33 p.m., Andreas Sturmlechner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127230/
> -----------------------------------------------------------
> 
> (Updated Feb. 29, 2016, 10:33 p.m.)
> 
> 
> Review request for KDEPIM and Laurent Montel.
> 
> 
> Repository: kdepim
> 
> 
> Description
> -------
> 
> I would like to gather opinions here. Dissolving the console subdirectory and moving its two projects directly under kdepim.git/ makes handling them the same as all the other parts of kdepim, and packaging a bit more convenient. Apart from the bulk move, the changes required are minimal. These applications can be built independently from the rest, and nothing depends on them.
> 
> At the same time, provide these 'administrative' applications - including akonadiconsole - via ecm_optional_add_subdirectory.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 63384efb9c495bd3f9f2b507ef747cac7844deaa 
>   Mainpage.dox 50eef0a2e404b0df253afebd48d8b121cf71ad41 
>   console/CMakeLists.txt c17612249371d50c02641fd777900b81976fafd3 
>   console/Mainpage.dox c6cfb40831b6c4893b74da4a86e80785caf091c8 
>   console/calendarjanitor/CMakeLists.txt 36d322a0e9f505f2e6c96c5275c65321cec8edfa 
>   console/calendarjanitor/COPYING  
>   console/calendarjanitor/Messages.sh  
>   console/calendarjanitor/backuper.h  
>   console/calendarjanitor/backuper.cpp  
>   console/calendarjanitor/calendarjanitor.h  
>   console/calendarjanitor/calendarjanitor.cpp  
>   console/calendarjanitor/collectionloader.h  
>   console/calendarjanitor/collectionloader.cpp  
>   console/calendarjanitor/main.cpp  
>   console/calendarjanitor/options.h  
>   console/calendarjanitor/options.cpp  
>   console/konsolekalendar/CMakeLists.txt 7b0c6e099905f917a4c54c53814b78bcd115db77 
>   console/konsolekalendar/COPYING  
>   console/konsolekalendar/HACKS  
>   console/konsolekalendar/Mainpage.dox  
>   console/konsolekalendar/Messages.sh  
>   console/konsolekalendar/ROADMAP  
>   console/konsolekalendar/TODO  
>   console/konsolekalendar/examples/README  
>   console/konsolekalendar/examples/tcm2kcal.pl  
>   console/konsolekalendar/examples/testkalendar.sh  
>   console/konsolekalendar/konsolekalendar.cpp  
>   console/konsolekalendar/konsolekalendar.desktop  
>   console/konsolekalendar/konsolekalendar.h  
>   console/konsolekalendar/konsolekalendaradd.h  
>   console/konsolekalendar/konsolekalendaradd.cpp  
>   console/konsolekalendar/konsolekalendarchange.h  
>   console/konsolekalendar/konsolekalendarchange.cpp  
>   console/konsolekalendar/konsolekalendardelete.h  
>   console/konsolekalendar/konsolekalendardelete.cpp  
>   console/konsolekalendar/konsolekalendarepoch.h  
>   console/konsolekalendar/konsolekalendarepoch.cpp  
>   console/konsolekalendar/konsolekalendarexports.h  
>   console/konsolekalendar/konsolekalendarexports.cpp  
>   console/konsolekalendar/konsolekalendarvariables.h  
>   console/konsolekalendar/konsolekalendarvariables.cpp  
>   console/konsolekalendar/main.cpp  
>   console/konsolekalendar/pics/128-apps-konsolekalendar.png  
>   console/konsolekalendar/pics/16-apps-konsolekalendar.png  
>   console/konsolekalendar/pics/22-apps-konsolekalendar.png  
>   console/konsolekalendar/pics/32-apps-konsolekalendar.png  
>   console/konsolekalendar/pics/48-apps-konsolekalendar.png  
>   console/konsolekalendar/pics/CMakeLists.txt  
> 
> Diff: https://git.reviewboard.kde.org/r/127230/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andreas Sturmlechner
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/