[Kde-pim] Review Request 124987: Avoid mimeType not emitted warnings with kio_pop3

[Andreas Sturmlechner]

> On June 13, 2016, 6:13 p.m., Andreas Sturmlechner wrote:
> > Unfortunately, a Gentoo user has found a problem with this commit where POP3 resource would stop to fetch mails: https://forums.gentoo.org/viewtopic-t-1046400.html
> > Reverting this one fixed it. Maybe your follow-up patch is more important than you thought (I don't see one applied), could you have another look at it?
> 
> Michael Pyne wrote:
>     The follow-up patch was commit d0958cb91c32c72127305e684a70e0d416ff6aa3 in kdepim-runtime to adjust /resources/pop3 (see also RR 124988).
>     
>     However I see that I neglected to push my forward-port commit in master, but if the user had also upgraded kdepim-runtime to 4.14.11 (after 2015-09-05) then it might be a problem after all. It's unclear from the Gentoo forums thread if the two were upgraded at the same time. Since the current patch sends a POP3 error response (per the spec!) if a RETR verb is sent without a msgid, it seems that you'd need the corrected kdepim-runtime to ensure that this POP3 error is not encountered.
>     
>     My apologies though as I should have sent a message to kde-distro-packagers to warn them of the need to coordinate upgrades of these two.
>     
>     Before I start trying to revert this (it's been working fine here) is it possible to see if the user also tested with upgraded kdepim-runtime packages?
> 
> Andreas Sturmlechner wrote:
>     Gentoo stabilised all of KDE PIM 4.14.11_pre20160211 snapshots at once, while the user isn't specific about all involved versions, those must be ones they are talking about. The following dependency chain would make sure that correct versions are installed: kmail-4.14.11_pre20160211 pulls in >=kdepim-common-libs-4.14.11_pre20160211 which in turn pulls in >=kdepim-runtime-4.14.11_pre20160211
>     
>     I'll try to get a precise answer still.

Very sorry for the noise, this is indeed a case of kmail1 usage - which still needs kdepimlibs, but has no kdepim-runtime, so the fix is not obvious right now. Obviously you don't need to care about kmail1.


- Andreas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124987/#review96427
-----------------------------------------------------------


On Sept. 6, 2015, 12:23 a.m., Michael Pyne wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124987/
> -----------------------------------------------------------
> 
> (Updated Sept. 6, 2015, 12:23 a.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Repository: kdepimlibs
> 
> 
> Description
> -------
> 
> Several of the POP3 commands in the POP3 kioslave return their data without emitting a mimetype, which leads to annoying warnings in the console output.
> 
> 2 of the commands (LIST and UIDL) just return a list of messages and their sizes/IDs; for these I simply gave them a text/plain and went about my day, though there may be something more appropriate.
> 
> The final command giving a warning (RETR %1) seems to be a bug in the akonadi_pop3 resource, where the resource asks for a message download without giving the ID. I have a separate patch to correct that. With that said, the bug is still a POP3 error so we check for that and bail out in that case, instead of sending an empty QByteArray() just to call finished().
> 
> I know "no one uses POP3 anymore" but this would help me out at least. :)
> 
> 
> Diffs
> -----
> 
>   kioslave/pop3/pop3.cpp 2073095 
> 
> Diff: https://git.reviewboard.kde.org/r/124987/diff/
> 
> 
> Testing
> -------
> 
> Have received a normal amount of emails with the patch applied, am able to move messages, etc. So things look like they're working, though it's certainly possible I've missed something.
> 
> 
> Thanks,
> 
> Michael Pyne
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/