[Kde-pim] [Differential] [Changed Subscribers] D2038: A new akonadi resource type implementing the Tomboy REST API

[mlaurent (Laurent Montel)]

mlaurent added inline comments.

INLINE COMMENTS

> o1tomboy.h:1
> +#ifndef O1TOMBOY_H
> +#define O1TOMBOY_H

Missing copyright ?

> o1tomboy.h:9
> +public:
> +    explicit O1Tomboy(QObject *parent = 0) : O1(parent) {
> +

Q_NULLPTR

> tomboycollectionsdownloadjob.cpp:14
> +
> +Akonadi::Collection::List TomboyCollectionsDownloadJob::collections()
> +{

const

> tomboycollectionsdownloadjob.h:12
> +    // ctor
> +    explicit TomboyCollectionsDownloadJob(const QString &collectionName, KIO::AccessManager *manager, QObject *parent = 0);
> +    // returns the parsed results wrapped in Akonadi::Collection::List, see bellow

Q_NULLPTR

> tomboyitemdownloadjob.h:11
> +public:
> +    TomboyItemDownloadJob(const Akonadi::Item &item, KIO::AccessManager *manager, QObject *parent = 0);
> +    // returns the parsed results wrapped in Akonadi::Item, see bellow

Q_NULLPTR

> tomboyitemsdownloadjob.h:12
> +    // ctor
> +    TomboyItemsDownloadJob(const Akonadi::Collection::Id &id, KIO::AccessManager *manager, QObject *parent = 0);
> +    // returns the parsed results wrapped in Akonadi::Item::List, see bellow

explicit + Q_NULLPTR

> tomboyitemuploadjob.h:19
> +public:
> +    TomboyItemUploadJob(const Akonadi::Item &item, JobType jobType, KIO::AccessManager *manager, QObject *parent = 0);
> +

Q_NULLPTR

> tomboyjobbase.cpp:6
> +    : KCompositeJob(parent)
> +{
> +    // Create the OAuth objects

initialize mReply to Q_NULLPTR in the constructor

REPOSITORY
  rMESSAGELIB PIM: Message Library

REVISION DETAIL
  https://phabricator.kde.org/D2038

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: Stefan, #kde_pim, dvratil
Cc: mlaurent, knauss, dvratil, kde-pim, dvasin, winterz, smartins, vkrause
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/