[Kde-pim] [Differential] [Commented On] D2050: korgac: only try to start Akonadi if it has been configured

[winterz (Allen Winter)]

winterz added a comment.


  In https://phabricator.kde.org/D2050#37833, @dvratil wrote:
  
  > In https://phabricator.kde.org/D2050#37829, @winterz wrote:
  >
  > > code looks good.
  > >  I suppose the simple existence of the akonadiserverrc file is a good enough semaphore, although I might like to see an "enabled=[true|false]" key value pair in the rc file to make sure.   in any event, +1 from me.
  >
  >
  > If you mean "enabled" as in if korgac is enabled, then that's already handled by the condition in the autostart .desktop file:
  >
  >   X-KDE-autostart-condition=korgacrc:General:Autostart:true
  >
  >
  > So when user disables korgac, it won't even start, so no problem with it inadvertently starting Akonadi.
  
  
  No I mean that you are relying only on the existence of akonadiserverrc and not any contents inside akonadiserverrc.
  so even a 0-byte file would mean "yep, akonadi server is setup".  A little more robust would be some flag inside akonadiserverrc letting us know that in fact the user has setup akonadi.  no biggie.

REPOSITORY
  rKDEPIM KDE PIM

REVISION DETAIL
  https://phabricator.kde.org/D2050

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: dvratil, kde-pim
Cc: winterz, dvasin, smartins, vkrause, mlaurent, knauss, dvratil
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/