[Kde-pim] [Differential] [Updated] D2038: A new akonadi resource type implementing the Tomboy REST API

[Stefan (Stefan Staeglich)]

Stefan marked an inline comment as done.
Stefan added a comment.


  More comments

INLINE COMMENTS

> dvratil wrote in tomboycollectionsdownloadjob.cpp:53
> Does `collectionRevision.toString()` actually work if `collectionRevision` contains a number? If not, fix this, if it does, use it above instead of `QString::number`

I don't think that this works. AFAIK I've tested it. collectionRevision in JSON is a number, and numbers in JSON are without "" stored, but strings are stored with ""

> dvratil wrote in tomboynotesresource.cpp:188
> Ouch, really? Look into using `KIO::SslUi::askIgnoreSslErrors()` or `KSslInfoDialog`...

I'll do it in a later version

> dvratil wrote in tomboyserverauthenticatejob.cpp:67
> How do you know that user has finished the authentication and the OAuth authorization can continue?
> 
> IMO it would be better to use a custom dialog with `QWebEngineView` rather than launching user's browser.
> 
> You should at least check if the call is successful and show an error message otherwise.

Good point. I'll check this.

REPOSITORY
  rKDEPIMRUNTIME KDE PIM Runtime

REVISION DETAIL
  https://phabricator.kde.org/D2038

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: Stefan, #kde_pim, dvratil
Cc: mlaurent, knauss, dvratil, kde-pim, dvasin, winterz, smartins, vkrause
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/