[Kde-pim] [Differential] [Commented On] D1990: Show spam status in 5.2 header

[knauss (Sandro Knauß)]

knauss added a comment.


  So to summerize:
  
  - spam status in 5.2 theme
  - delete config for disable spam status completly
  - fix notranslated header fields ( in seperate patch)
  - add a 5.2 variant without spam header y/n?
  - do not use i18n grantlee support for string, that will be also put into others themes

INLINE COMMENTS

> mlaurent wrote in header.html:83
> +1 don't move i18n in grantlee support otherwise we will lose translation for other theme.

but external apps can also load the translations of messageviewer/ kdepim-addons  so we would not nessarily loos the that with  grantlee i18n support. But in the end it is a code desgin desision.

REPOSITORY
  rKDEPIMADDONS KDE PIM Addons

REVISION DETAIL
  https://phabricator.kde.org/D1990

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: knauss, colomar, mlaurent
Cc: dvratil, kde-pim, dvasin, winterz, smartins, vkrause, mlaurent, knauss
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/