[Kde-pim] Review Request 128383: Fix bug with events ending at midnight

[Sandro Knauß]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128383/#review97207
-----------------------------------------------------------




autotests/testevent.cpp (line 269)
<https://git.reviewboard.kde.org/r/128383/#comment65648>

    Please hardcode the startdate and time.
    
    Because the tests can fail if you run it around 0:00 o'clock.
    
    Also it can happen strange things if we start the test around new year eve.
    
    I know we have this pattern `QDate::currentDate()` a lot in the tests and we see these failing tests at strange times :(
    That's why we should remove these patternand add tests to make sure, that we also working correct at these dates.
    
    That's why you should also add the interessting Dates (31-12-2016 0:00:00/0:00:01/12:00:00 - 1-1-2017 0:00:00/0:00:01/12:00:00), too. This way we make sure, that it also works at these critical dates.
    
    Also it may makes sense to use the test `_data` pattern, because now we have additional three testdates we wanna test (see testSerializer_data / testSerializer in the same file, how to write these).
    
    If you have any questions please do not hesitate to ask.


- Sandro Knauß


On July 8, 2016, 9:43 a.m., Bastian Köcher wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128383/
> -----------------------------------------------------------
> 
> (Updated July 8, 2016, 9:43 a.m.)
> 
> 
> Review request for KDEPIM, Sandro Knauß and Allen Winter.
> 
> 
> Bugs: 362921
>     https://bugs.kde.org/show_bug.cgi?id=362921
> 
> 
> Repository: kcalcore
> 
> 
> Description
> -------
> 
> This fixes the bug with events that end at midnight and are displayed for multiple days.
> 
> 
> Diffs
> -----
> 
>   autotests/testevent.h edb5ef7 
>   autotests/testevent.cpp 25ffbec 
>   src/event.cpp 840905e 
> 
> Diff: https://git.reviewboard.kde.org/r/128383/diff/
> 
> 
> Testing
> -------
> 
> make test hangs at "Start 368: RecursOn-RFC2445_RRULETest39.ics", but without my change is seems to be hanging there too.
> 
> 
> Thanks,
> 
> Bastian Köcher
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/