[Kde-pim] Review Request 128347: Fix assert in CollectionFetchJob when cols is empty.

Laurent Montel montel at kde.org
Sat Jul 2 21:35:42 BST 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128347/#review97037
-----------------------------------------------------------


Ship it!




Seems logical
+2

- Laurent Montel


On July 2, 2016, 8:20 p.m., David Faure wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128347/
> -----------------------------------------------------------
> 
> (Updated July 2, 2016, 8:20 p.m.)
> 
> 
> Review request for KDEPIM and Laurent Montel.
> 
> 
> Repository: messagelib
> 
> 
> Description
> -------
> 
> If Akonadi::PersistentSearchAttribute::queryCollections() returns
> an empty list of collections, this code would assert.
> 
> 
> Diffs
> -----
> 
>   messagelist/src/core/widgets/searchcollectionindexingwarning.cpp e8b5cb49eb3aaf2687e313deed7ef28aa79b9b4a 
> 
> Diff: https://git.reviewboard.kde.org/r/128347/diff/
> 
> 
> Testing
> -------
> 
> Got an assert when clicking on "Open Search Folder" in the kmail search dialog (not sure if reproducible).
> 
> 
> Thanks,
> 
> David Faure
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


More information about the kde-pim mailing list