[Kde-pim] Review Request 128438: akregator: Initialise KCrash

[Heiko Becker]

> On Juli 13, 2016, 5:09 nachm., Laurent Montel wrote:
> > Work fine here. I can crash and see bug report.
> > I don't know why it's necessary

Does your akregator executable link to KF5Crash (pulled in via one of its dependencies)? I have --as-needed in LDFLAGS which strips way linking to KF5Crash if it isn't actually used. This has already been discussed here: https://mail.kde.org/pipermail/kde-frameworks-devel/2015-November/028630.html

Furthermore, it's what the API docs say ("Call this in your main() to ensure that the crash handler is always launched.") and it seems to be needed for quite a number of other projects.


- Heiko


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128438/#review97353
-----------------------------------------------------------


On Juli 13, 2016, 2:48 nachm., Heiko Becker wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128438/
> -----------------------------------------------------------
> 
> (Updated Juli 13, 2016, 2:48 nachm.)
> 
> 
> Review request for KDEPIM and Laurent Montel.
> 
> 
> Repository: kdepim
> 
> 
> Description
> -------
> 
> Otherwise DrKonqi isn't started when akregator crashes.
> 
> 
> Diffs
> -----
> 
>   akregator/CMakeLists.txt 789fd4f04c9b780e5bb10a91ba8fec082cd3aa7f 
>   akregator/src/CMakeLists.txt c49cbe51e8e37a2a3c9327f95a56bdc9ffad9ee3 
>   akregator/src/main.cpp c1384cf5541bb148b81bd96063929c1460e5f108 
> 
> Diff: https://git.reviewboard.kde.org/r/128438/diff/
> 
> 
> Testing
> -------
> 
> DrKonqi is started after a crash and I successfully reported a bug with it.
> 
> 
> Thanks,
> 
> Heiko Becker
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/