[Kde-pim] [Differential] [Changed Subscribers] D2254: Extend IdentityTest and fix all bugs it discovered

[knauss (Sandro Knauß)]

knauss added inline comments.

INLINE COMMENTS

> identitytest.cpp:166
> +        QVERIFY(compareIdentities(copy, identity));
> +    }
> +

you should also test the negativ outcome, so that you really make sure, that the == operator not just always return true :)

Something like

  copy.setXFace(QStringLiteral(":-("))
  QCOMPARE(copy == identity, false);

REPOSITORY
  rKIDENTITYMANAGEMENT PIM: KIdentity Management

REVISION DETAIL
  https://phabricator.kde.org/D2254

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: dvratil, kde-pim
Cc: knauss, mlaurent, dvasin, winterz, smartins, vkrause, dvratil
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/