[Kde-pim] [Differential] [Accepted] D2038: A new akonadi resource type implementing the Tomboy REST API

[knauss (Sandro Knauß)]

knauss accepted this revision.
knauss added a reviewer: knauss.
knauss added a comment.


  looks fine for me.

INLINE COMMENTS

> README:23
> +
> +I changed only the o2 includes and the code style. The changes are documented
> +in o2/changes.patch.

argh - never ever make whitespace changes (codestlye change)  to a (temp) copy of a library. Because this makes the diff much bigger and harder to see, what you changed that matters.

REPOSITORY
  rKDEPIMRUNTIME KDE PIM Runtime

REVISION DETAIL
  https://phabricator.kde.org/D2038

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: Stefan, dvratil, #kde_pim, knauss
Cc: krake, mlaurent, knauss, dvratil, kde-pim, dvasin, winterz, smartins, vkrause
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/