[Kde-pim] [Differential] [Commented On] D2038: A new akonadi resource type implementing the Tomboy REST API

[dvratil (Daniel Vrátil)]

dvratil added inline comments.

INLINE COMMENTS

> CMakeLists.txt:1-5
> +remove_definitions(-DQT_NO_URL_CAST_FROM_STRING
> +                   -DQT_NO_CAST_FROM_BYTEARRAY
> +                   -DQT_USE_QSTRINGBUILDER
> +                   -DQT_USE_FAST_OPERATOR_PLUS
> +)

This will unfortunately affect your resource code too, even though it's only needed because of o2 :-(

You could add a CMakeLists.txt to the o2 subdirectory, where you remove these definitions and build the o2 library as a static library. Then you just put add_subdirectory(o2) here and you are done.

> CMakeLists.txt:19-31
> +    o1tomboy.cpp
> +    o2/o0settingsstore.cpp
> +    o2/o0baseauth.cpp
> +    o2/o0abstractstore.h
> +    o2/o0globals.h
> +    o2/o1.cpp
> +    o2/o1requestor.cpp

If you go for the approach described above, remove those files from here.

> CMakeLists.txt:60
> +target_link_libraries(akonadi_tomboynotes_resource
> +    o2
> +    Qt5::DBus

If you don't go for the approach described above (i.e. you stick to what you have now), then remove this, because in that case there won't be any "o2" library to link against.

REPOSITORY
  rKDEPIMRUNTIME KDE PIM Runtime

REVISION DETAIL
  https://phabricator.kde.org/D2038

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: Stefan, #kde_pim, dvratil
Cc: krake, mlaurent, knauss, dvratil, kde-pim, dvasin, winterz, smartins, vkrause
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/