[Kde-pim] [Differential] [Commented On] D2247: AccountWizard: add option to configure default crypto behaviour for new identity

knauss (Sandro Knauß) noreply at phabricator.kde.org
Fri Jul 22 11:50:47 BST 2016


knauss added inline comments.

INLINE COMMENTS

> personaldatapage.cpp:4


shouldn't we move the enum to the file namespace? So also other methods can use it?

I would suggest to create a method aka:

  CryptoState PersonalDataPage::cryptoState() const{
           return static_cast<CryptoState>(ui.cryptoComboBox->currentIndex());
  }

REVISION DETAIL
  https://phabricator.kde.org/D2247

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: dvratil, #kde_pim
Cc: knauss, kde-pim, aheinecke, mlaurent, dvasin, winterz, smartins, vkrause, dvratil
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


More information about the kde-pim mailing list