[Kde-pim] [Differential] [Commented On] D2038: A new akonadi resource type implementing the Tomboy REST API

[Stefan (Stefan Staeglich)]

Stefan added inline comments.

INLINE COMMENTS

> knauss wrote in README:14
> Add a note that you have a copy of the o2 lib inside the sudir o2 and the lisnce of that lib + the git checkout.
>  + document every change to the libriary as a set of patches ( if you made any changes that are not upstream)
> 
> Btw distributions are mostly not happy with copies of libraries, so they wanna strip this out again. If the library ( I know that Dan suggested you to ship a copy).
> 
> So if we can delete the copy with the nexit iteration, it would be great.

Yes thats my plan. I don't want to ship o2 forever.

> knauss wrote in o0abstractstore.h:1
> nippicking: missing lisence header  - this is something that upstream should fix and not you with the copy, but please inform upstream about this.

I'll inform him

REPOSITORY
  rKDEPIMRUNTIME KDE PIM Runtime

REVISION DETAIL
  https://phabricator.kde.org/D2038

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: Stefan, #kde_pim, dvratil
Cc: krake, mlaurent, knauss, dvratil, kde-pim, dvasin, winterz, smartins, vkrause
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/