[Kde-pim] [Differential] [Request, 43 lines] D2161: MessageViewer plugin: create EventEdit widget on demand.

[dfaure (David Faure)]

dfaure created this revision.
dfaure added a reviewer: mlaurent.
dfaure added a subscriber: KDE PIM.
Restricted Application added a project: KDE PIM.
Restricted Application added a subscriber: kde-pim.

REVISION SUMMARY
  This avoids creating a CollectionComboBox on startup (which includes a Monitor,
  an ETM and 3 proxies on top), which might never be used if the user doesn't
  use the "create event" feature.
  
  The same change should of course be done to noteedit and todoedit.
  
  The unittest had to be adjusted because it was checking that the widget
  was created upfront and hidden, which is exactly what this patch changes.

TEST PLAN
  Ctrl+E in kmail still brings up the event edit widget,
  without any noticeable delay the first time.

REPOSITORY
  rKDEPIMADDONS KDE PIM Addons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D2161

AFFECTED FILES
  plugins/messageviewerplugins/autotests/viewerplugincreateeventtest.cpp
  plugins/messageviewerplugins/autotests/viewerplugincreateeventtest.h
  plugins/messageviewerplugins/createeventplugin/viewerplugincreateeventinterface.cpp
  plugins/messageviewerplugins/createeventplugin/viewerplugincreateeventinterface.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: dfaure, mlaurent
Cc: kde-pim, #kde_pim, dvasin, winterz, smartins, vkrause, mlaurent, knauss, dvratil
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/