[Kde-pim] Review Request 126850: [akonadi] Add switch to build development/testing tools optionally

Andreas Sturmlechner andreas.sturmlechner at gmail.com
Fri Jan 22 20:16:27 GMT 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126850/
-----------------------------------------------------------

Review request for Akonadi and Daniel Vrátil.


Repository: akonadi


Description
-------

BUILD_TESTING=TRUE currently alters the install image, this change introduces BUILD_TOOLS to conditionally build
- akonadixml
- akonaditest
- akonadi_knut_resource
- akonadi_test_searchplugin
BUILD_TESTING=TRUE however will still trigger BUILD_TOOLS=TRUE.

Before the merge into akonadi.git, these testing tools subdirs were already (partially) moved into the root CMakeLists.txt, albeit without a switch, but that got lost with the merge again.

As a bonus, LibXML2 detection is moved into xml subdir where it is actually used. However, I've noticed akonadixml defines HAVE_LIBXML2 and it actually also builds without it - so I've made it optional at the same time. Requesting comments on that since I don't know if it was made required for a specific reason. ;)


Diffs
-----

  CMakeLists.txt 503ba48030b35cff160b776a8722c429de52f08c 
  autotests/libs/CMakeLists.txt 562454d2555a46449457bb8561cd94b51d442564 
  src/CMakeLists.txt 4e79dc02e8313ed8c6177961733447fe3c0bd333 
  src/xml/CMakeLists.txt ad116d8edc77efc300872e330121ab5ad1f716f9 

Diff: https://git.reviewboard.kde.org/r/126850/diff/


Testing
-------


Thanks,

Andreas Sturmlechner

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


More information about the kde-pim mailing list