[Kde-pim] Review Request 126847: Enable standalone build of Kleopatra
Laurent Montel
montel at kde.org
Mon Jan 25 09:05:09 GMT 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126847/#review91571
-----------------------------------------------------------
kleopatra/conf/CMakeLists.txt (line 23)
<https://git.reviewboard.kde.org/r/126847/#comment62576>
Perhaps use ${kleopatra_SOURCE_DIR}/.......
no ?
- Laurent Montel
On jan. 25, 2016, 8:55 matin, Andre Heinecke wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126847/
> -----------------------------------------------------------
>
> (Updated jan. 25, 2016, 8:55 matin)
>
>
> Review request for KDEPIM.
>
>
> Repository: kdepim
>
>
> Description
> -------
>
> This enables a standalone build of the Kleopatra subdirectory without the need to compile other parts of KDEPIM.
>
> It is intended as the first step to move Kleopatra into it's own repository.
>
> This also removes FindGpgme. This was not neccessary as gpgme is pulled in through gpgmepp
>
> The Libassuan handling in Kleopatra is horrible and not neccessary anymore. We can assume that if libassuan is available that it's libassuan2. For now I've added a dirty failure in case Assuan2 is not found. I plan to rewrite the Assuan finding stuff so that it behaves like a normal FindAssuan.cmake file, but this is something for another patch.
>
>
> Diffs
> -----
>
> CMakeLists.txt 5ad586c
> cmake/modules/FindAssuan.cmake a8c7d64
> cmake/modules/FindAssuan2.cmake 29cce38
> cmake/modules/FindGpgme.cmake 9db4e50
> kleopatra/CMakeLists.txt 16bbd28
> kleopatra/ConfigureChecks.cmake 51cede5
> kleopatra/cmake/modules/FindAssuan2.cmake PRE-CREATION
> kleopatra/conf/CMakeLists.txt be0f89f
> kleopatra/uiserver/assuanserverconnection.cpp 6ab5c14
>
> Diff: https://git.reviewboard.kde.org/r/126847/diff/
>
>
> Testing
> -------
>
> Compiled a copy of the kleopatra subdirectory.
> Compiled KDEPIM repository.
>
>
> Thanks,
>
> Andre Heinecke
>
>
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/
More information about the kde-pim
mailing list