[Kde-pim] Review Request 126703: Use KSharedConfig::openConfig("kmail2rc") to try and optimize away reparsing.

David Faure faure at kde.org
Sun Jan 10 17:03:35 GMT 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126703/
-----------------------------------------------------------

(Updated Jan. 10, 2016, 5:03 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDEPIM-Libraries and Laurent Montel.


Changes
-------

Submitted with commit b3e1fb500d91ac167bcfcbb3bc5a85cbba7a6f57 by David Faure to branch master.


Repository: kidentitymanagement


Description
-------

Of course it only helps if we're called by kmail or kontact, not that
much in standalone korganizer.

At least KIdentityManagement::thatIsMe has a cache, unlike the kde4 version
of kcalutils/incidenceformatter.cpp's thatIsMe which created an IdentityManager
instance every time (which made me look into this).


Diffs
-----

  src/identitymanager.cpp 8fa5beede24d948401193be0e450e06644e3fbe0 

Diff: https://git.reviewboard.kde.org/r/126703/diff/


Testing
-------

Compiles, kpimidentity-identitytest passes.


Thanks,

David Faure

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


More information about the kde-pim mailing list