[Kde-pim] Review Request 126911: Set input encoding for *.desktop files of the agents

[Daniel Vrátil]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126911/#review91699
-----------------------------------------------------------


Ship it!




Looks good, thanks!

- Daniel Vrátil


On Jan. 28, 2016, 9:35 a.m., Alexey Chernov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126911/
> -----------------------------------------------------------
> 
> (Updated Jan. 28, 2016, 9:35 a.m.)
> 
> 
> Review request for Akonadi and Daniel Vrátil.
> 
> 
> Bugs: 358658
>     http://bugs.kde.org/show_bug.cgi?id=358658
> 
> 
> Repository: akonadi
> 
> 
> Description
> -------
> 
> It turned out that *.desktop files of Akonadi agents is imported with the incorrect encoding, so the AgentType objects are initialized with broken strings when non-latin locale is used. The patch sets "UTF-8" encoding of QSettings explicitly and removes any other conversion from UTF-8 as it's converted just out-of-the-box.
> 
> 
> Diffs
> -----
> 
>   src/akonadicontrol/agenttype.cpp 2741f5b 
> 
> Diff: https://git.reviewboard.kde.org/r/126911/diff/
> 
> 
> Testing
> -------
> 
> Tested on Akonadi-15.12.1, with KMail and Akonadiconsole clients where the problem was initially found. Applying the patch fixes it.
> 
> 
> Thanks,
> 
> Alexey Chernov
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/