[Kde-pim] Review Request 126768: Make favicon fetching async

[Laurent Montel]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126768/#review91180
-----------------------------------------------------------


Ship it!




Seems ok.
(David works on a code with will not use qdbus for favicon)
But ship it :)
thanks

- Laurent Montel


On jan. 16, 2016, 2:24 après-midi, Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126768/
> -----------------------------------------------------------
> 
> (Updated jan. 16, 2016, 2:24 après-midi)
> 
> 
> Review request for KDEPIM and Laurent Montel.
> 
> 
> Repository: kdepim
> 
> 
> Description
> -------
> 
> My kded is acting up (https://bugs.kde.org/show_bug.cgi?id=358017) and this rendered akregator unusable.
> 
> It's not a proper reason but it's also not good to use ::call anyway, so I decided to use async calls which is better anyway.
> 
> 
> Diffs
> -----
> 
>   akregator/src/feed/feediconmanager.cpp c3edf34 
> 
> Diff: https://git.reviewboard.kde.org/r/126768/diff/
> 
> 
> Testing
> -------
> 
> Now I can use it.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/