[Kde-pim] Review Request 126915: Remove redundant icons (*-mimetypes-x-mail-distribution-list.png)

Laurent Montel montel at kde.org
Thu Jan 28 13:05:21 GMT 2016



> On jan. 28, 2016, 11:31 matin, Daniel Vrátil wrote:
> > You need to update minimum KF5 dependency to 5.19 now to ensure that the icons are always available.
> 
> Laurent Montel wrote:
>     icons are in new  kf5 5.19 ?
> 
> Daniel Vrátil wrote:
>     Apparently they were added to oxygen-icons5 5 days ago, so they will be available since 5.19.

So we will commit this patch when kf5.19 will release but for sure we will depend against it for 16.08 we will apply it.
But it's not the good time yet for increase this dependancy. (I wait patch from david for depend against it)


- Laurent


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126915/#review91700
-----------------------------------------------------------


On jan. 28, 2016, 9:43 matin, Elias Probst wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126915/
> -----------------------------------------------------------
> 
> (Updated jan. 28, 2016, 9:43 matin)
> 
> 
> Review request for KDEPIM-Libraries and Laurent Montel.
> 
> 
> Bugs: 358669
>     http://bugs.kde.org/show_bug.cgi?id=358669
> 
> 
> Repository: kdepimlibs
> 
> 
> Description
> -------
> 
> The `mimetypes-x-mail-distribution-list` icon is now also provided by
> `oxygen-icons5` which causes a collision with `kdepimlibs`.
> 
> BUG: 358669
> 
> 
> Diffs
> -----
> 
>   akonadi-contact/src/CMakeLists.txt a3201748a06c78df1d4201fb3455f26358bd46d3 
>   akonadi-contact/src/icons/128-mimetypes-x-mail-distribution-list.png ed9a320d5ab5cd5a3ebb8e5a158da1d9256b5bac 
>   akonadi-contact/src/icons/16-mimetypes-x-mail-distribution-list.png d010161028706c9533efcf2e2aeee14889043679 
>   akonadi-contact/src/icons/22-mimetypes-x-mail-distribution-list.png da48b182e15a33bfcc0d91bbb1c3c5fe8c943cf9 
>   akonadi-contact/src/icons/256-mimetypes-x-mail-distribution-list.png a457fedbc59a8a1b1546b19a5a6a45dc9f131205 
>   akonadi-contact/src/icons/32-mimetypes-x-mail-distribution-list.png 9a1f551591b49dfc5a26094d7a5ce462856f93c2 
>   akonadi-contact/src/icons/48-mimetypes-x-mail-distribution-list.png e5577d08aeb7ab0bc7991f08e2bf6c04a0e69aa3 
>   akonadi-contact/src/icons/512-mimetypes-x-mail-distribution-list.png 7215ffdc98aebac93a881852156563e02c04608b 
>   akonadi-contact/src/icons/CMakeLists.txt 0fe2465612a57cf3f0c9a928db384537a3e5af3c 
>   akonadi-contact/src/icons/oxsc-mimetypes-x-mail-distribution-list.svgz 1af3dfef4908f9b488bac65df9fc314c8e0a9b71 
> 
> Diff: https://git.reviewboard.kde.org/r/126915/diff/
> 
> 
> Testing
> -------
> 
> Installation succeeds now without any file collisions.
> 
> 
> Thanks,
> 
> Elias Probst
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


More information about the kde-pim mailing list