[Kde-pim] Review Request 126911: Set input encoding for *.desktop files of the agents

Alexey Chernov 4ernov at gmail.com
Thu Jan 28 13:37:13 GMT 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126911/
-----------------------------------------------------------

(Updated Jan. 28, 2016, 5:37 a.m.)


Status
------

This change has been marked as submitted.


Review request for Akonadi and Daniel Vrátil.


Changes
-------

Submitted with commit 1e164ae8d50b38c361595390543ebdeb45231777 by Alexey Chernov to branch master.


Bugs: 358658
    http://bugs.kde.org/show_bug.cgi?id=358658


Repository: akonadi


Description
-------

It turned out that *.desktop files of Akonadi agents is imported with the incorrect encoding, so the AgentType objects are initialized with broken strings when non-latin locale is used. The patch sets "UTF-8" encoding of QSettings explicitly and removes any other conversion from UTF-8 as it's converted just out-of-the-box.


Diffs
-----

  src/akonadicontrol/agenttype.cpp 2741f5b 

Diff: https://git.reviewboard.kde.org/r/126911/diff/


Testing
-------

Tested on Akonadi-15.12.1, with KMail and Akonadiconsole clients where the problem was initially found. Applying the patch fixes it.


Thanks,

Alexey Chernov

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


More information about the kde-pim mailing list