[Kde-pim] Review Request 126867: Speed up the default Identity() constructor.

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126867/
-----------------------------------------------------------

(Updated Jan. 26, 2016, 7:33 a.m.)


Status
------

This change has been marked as submitted.


Review request for KDEPIM-Libraries and Laurent Montel.


Changes
-------

Submitted with commit 9ce1b9856b13f485442c5600511b616ba47e455e by David Faure to branch KDE/4.14.


Repository: kdepimlibs


Description
-------

Sonnet::defaultLanguageName() is very slow (it parses 3 config files).
Sonnet is fixed in KF5, well, that method is gone and the call in identity.cpp
is commented out, but at least Sonnet has the default dict in a member var...

Testcase: opening a mail with an invitation took a very very long time before
rendering the invitation. Now it only takes a long time (ICAL parsing).


Diffs
-----

  kpimidentities/identity.cpp f644c7a225c1975a14b979db242bd25cdf0cb7b2 

Diff: https://git.reviewboard.kde.org/r/126867/diff/


Testing
-------

Opening an invitation email in kmail, and Ctrl+C in gdb to see what it's doing.

I did not test the handling of dictionaries in identities though.


Thanks,

David Faure

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/