[Kde-pim] Review Request 126601: Use Sasl2_INCLUDE_DIRS in kioslaves

Tobias Berner tcberner at gmail.com
Sat Jan 2 10:35:54 GMT 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126601/
-----------------------------------------------------------

Review request for KDEPIM-Libraries.


Repository: kdepimlibs


Description
-------

The cmake file kioslave/cmake/FindSasl2.cmake defines the
Sasl2 include path in Sasl2_INCLUDE_DIRS.
But
 * kioslaves/src/smtp/CMakeLists.txt
 * kioslave/src/smtp/tests/CMakeLists.txt
 * kioslaves/src/pop3/CMakeLists.txt
used the following
| [...] ${Sasl2_INCLUDE_DIR} [...]
Note the missing "S" at the end.

This leads to the following build error on FreeBSD
|[ 94%] Building CXX object kioslave/src/smtp/CMakeFiles/kio_smtp.dir/smtp.cpp.o
|/tmp/usr/ports/deskutils/kdepimlibs-kf5/work/kdepimlibs-15.12.0/kioslave/src/smtp/smtp.cpp:35:10: fatal error:
|      'sasl/sasl.h' file not found
|#include <sasl/sasl.h>
|         ^
|1 error generated.

This patch uses the correct Sasl2_INCLUDE_DIRS fixing this problem.


Diffs
-----

  kioslave/src/pop3/CMakeLists.txt 6433873 
  kioslave/src/smtp/CMakeLists.txt 9aba907 
  kioslave/src/smtp/tests/CMakeLists.txt d2d25db 

Diff: https://git.reviewboard.kde.org/r/126601/diff/


Testing
-------

build locally


Thanks,

Tobias Berner

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


More information about the kde-pim mailing list